Fuel Tank Mass Being Inconsistently Applied

[kennedy4273]

The mass of fuel tanks is being inconsistently applied. Take for example the Adder. If I just take the stock build [Figure 1], it has a laden mass of 82 T. However, if you look in the profiles section, you can see the dotted line indicating the "current" mass is actually closer to 90T, a full 8T above.

Now if I B rate a bunch of modules to make this chonky, and add a bunch of cargo racks, we encounter an example where this discrepancy causes problems [Figure 2]. These 2B thrusters have a listed maximum mass of 99T. We can also see that the maximum laden mass of this build, is also 99T. But the build shows as exceeding the max mass of the thrusters, even though this should be valid.

In [Figure 3], I've reduced the cargo a bit. The total mass should be 73T unladen +14T cargo, so 87T, but in the profiles section, the dotted line is at 95T!! Off once again by 8T, coincidentally the size of the fuel tank.

If I reduce the fuel tank size, we should get a mass of 69T unladen + 14T cargo, 83T total, however in the profiles view, the displayed tonnage is 87T, 4T over, the size of the fuel tank. [Figure 4]

Here's the default Beluga build. Max Laden mass is listed as 1686T, but the profiles view shows over 1800T as current. 1686+128 = 1814. [Figure 5]

The main issue is that the thruster calculation, and perhaps others, are using the calculation that drives the profile view, instead of what it should be. Perhaps the fuel tank is being considered as having mass of it's own, even though I don't think it should.

[alex-williams]

Thanks for such a detailed report, if only all bug reports were so meticulous! I'll get to this soon, but we're moving house in a few days time and I'm not likely to have internet at the new place for a few weeks, sadly.

[lyravega]

I believe this line might be the culprit. It includes fuel capacity in the unladen mass:

this.unladenMass = unladenMass + fuelCapacity;