Benchmarks icon indicating copy to clipboard operation
Benchmarks copied to clipboard

Data preprocessing: normalization

Open Deathn0t opened this issue 7 years ago • 2 comments

Hello,

I was looking at this baseline: https://github.com/ECP-CANDLE/Benchmarks/blob/release_01/Pilot1/Combo/combo_baseline_keras2.py

I was asking myself if the data are already preprocessed/normalized because I don't see any preprocessing function.

Deathn0t avatar Nov 15 '18 21:11 Deathn0t

Check ComboDataLoader and generator classes.

Sent from my iPhone

On Nov 15, 2018, at 3:27 PM, Romain Egele <[email protected]mailto:[email protected]> wrote:

Hello,

I was looking at this baseline: https://github.com/ECP-CANDLE/Benchmarks/blob/release_01/Pilot1/Combo/combo_baseline_keras2.py

I was asking myself if the data are already preprocessed/normalized because I don't see any preprocessing function.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/ECP-CANDLE/Benchmarks/issues/36, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABLd8xMHNx81XMSpf3mY_x0ASZJjNUEyks5uvdwbgaJpZM4Yi9f-.

hyoo avatar Nov 16 '18 03:11 hyoo

Oh yes I see, you are using the scaling argument.

so the mse compute on the validation set is using preprocessed data (evaluate_score), isn't it better to reverse the preprocessing before computing the mse between y_orig, y_pred ?

Deathn0t avatar Nov 16 '18 03:11 Deathn0t