Benchmarks icon indicating copy to clipboard operation
Benchmarks copied to clipboard

model_name required

Open rajeeja opened this issue 3 years ago • 5 comments

With the updates in candle_lib model_name is a required hyperparameter. Breaks UNO and might other Benchmarks also.

rajeeja avatar Jan 12 '23 16:01 rajeeja

Yes, I have updated all the benchmarks to comply. Did you find an error? First line of uno_default_model.txt is model_name

jmohdyusof avatar Jan 12 '23 16:01 jmohdyusof

Gotcha. Not all .txt files were changed. I was using uno_auc_model.txt in my fork. https://github.com/rajeeja/Benchmarks/tree/AUCstd1

rajeeja avatar Jan 12 '23 16:01 rajeeja

OK, I basically just swept all the xxx_default_model.txt files, I would have missed any secondary .txt files (most benchmarks do not have more than the default_model). I can sweep the others. We also need to fix the path issue

jmohdyusof avatar Jan 12 '23 17:01 jmohdyusof

Is --config_file broken?

rajeeja avatar Jan 12 '23 17:01 rajeeja

It is because Tom wanted non-default files to be in data_dir. I am working with Cristina to fix it

jmohdyusof avatar Jan 12 '23 17:01 jmohdyusof