e2openplugin-OpenWebif icon indicating copy to clipboard operation
e2openplugin-OpenWebif copied to clipboard

Concerns regarding CoPilot/AI suggestions and change requests

Open wedebe opened this issue 6 months ago • 16 comments

There has been a gamut of CoPilot-driven change requests in the last few hours alone.

Of particular concern is the sensibility of some suggestions, for example, directly modifying plugin code. One such example is Bootstrap Select: https://github.com/E2OpenPlugins/e2openplugin-OpenWebif/pull/1664

Such changes are likely to cause further trouble next time the libs are updated by dependabot, as the changes made will be undone. At the very least, such changes should be suggested directly to the Bootstrap Select plugin developers.

Additionally, even a wet-behind-the-ears junior developer should know better than to directly modify plugin code.

This - in my opinion at least - calls into question the viability of AI-powered "suggestions". Granted, people might feel that they're contributing in some meaningful way to various projects, but without oversight and stringent testing, such changes could cause breakage or regression bugs further down the line, by which time, someone will have to waste their time manually fixing up various issues.

Can CoPilot be disabled on this project until such a point as someone can dedicate their time to thoroughly testing all of the changes on a running instance of Enigma2 before they're merged? I and others have put countless hours into thoroughly testing any and every change we've made to OpenWebif; I'd hate to see it destroyed by constant, unrelenting, untested "tweaks".

https://www.theregister.com/2025/07/16/if_you_want_a_picture/

wedebe avatar Jul 21 '25 16:07 wedebe

Another one, directly and nonsensically changing a jQuery plugin's code

May I suggest rolling back any and all changes that have been made by this contributor, please, 'cos this is fast becoming a shitshow of random and quite possibly unneccessary changes. AI coding is the modern-day equivalent of asbestos.

Furthermore, allowing bots to make constant, unverified changes to code runs a SIGNIFICANT risk of malicious code being introduced, either in one fell swoop or piecemeal over a period of time, and quietly released to the wild.

Why are CoPilot/AI changes allowed to be merged without a requirement for peer review and approval?

wedebe avatar Jul 21 '25 16:07 wedebe

The question outside of your criticism is where you see mistakes. Can you describe that in more detail?

kueken avatar Jul 21 '25 16:07 kueken

@kueken , what is your experience with javascript? How many projects do you contribute to? Are you powered by AI?

wedebe avatar Jul 21 '25 16:07 wedebe

The question is what"s wrong and what"s bothering you now?

kueken avatar Jul 21 '25 16:07 kueken

You haven"t been here for years, what"s your appearance here now?

kueken avatar Jul 21 '25 16:07 kueken

Why are you directly modifying code in established js libraries and plugins?

wedebe avatar Jul 21 '25 16:07 wedebe

Where is your constructive contribution? The plugin has not been serviced and you know that very well. Everything is going in the direction of the OE Alliance and will then be updated there. Where is your error message now, or what exactly are you denouncing here? OE-A also works with bots. This is everyday life

kueken avatar Jul 21 '25 16:07 kueken

Can you confirm that you are a bot and guarantee you know what's best?

wedebe avatar Jul 21 '25 16:07 wedebe

You don"t report a bug here, you just want to argue. What is this?

kueken avatar Jul 21 '25 16:07 kueken

@kueken , have you tested these changes? If so,

  • on which device make and model have you tested your changes?
  • on which Enigma2 distro have you tested your changes?
  • which version of said distro have you tested your changes on?

wedebe avatar Jul 21 '25 16:07 wedebe

Where is your error message? What is this supposed to be?

kueken avatar Jul 21 '25 17:07 kueken

The error is 500 "this code has not been tested"

wedebe avatar Jul 21 '25 17:07 wedebe

Are you the bot now? What do you want?

kueken avatar Jul 21 '25 17:07 kueken

On behalf of all contributors to this project, I want you to hold yourself accountable for the changes you make.

So far you've only responded to every question with two questions of your own.

wedebe avatar Jul 21 '25 17:07 wedebe

So, there are still a number of python bugs in there. I"ve left them for you now. I have extra Ruff currently deactivated, because it detects the errors, but also falke8 describes the errors exactly. You know where you can find them.

It would be nice if you could make your obvious time available for this.

whatever you want to tell me, unfortunately I don"t understand you. But yes, this plugin certainly still has a few construction sites.

kueken avatar Jul 21 '25 17:07 kueken

https://github.com/E2OpenPlugins/e2openplugin-OpenWebif/issues/1635#issuecomment-1942767941

kueken avatar Jul 21 '25 21:07 kueken