e2openplugin-OpenWebif icon indicating copy to clipboard operation
e2openplugin-OpenWebif copied to clipboard

Remove VXGplayer

Open jbleyel opened this issue 5 years ago • 10 comments

We can remove the VXG, BUT, I do not want to make this decision alone.

See here -> https://github.com/E2OpenPlugins/e2openplugin-OpenWebif/issues/1208#issuecomment-758327263

jbleyel avatar Jan 12 '21 22:01 jbleyel

Yes, please do so. It seems to me that for future proof stream support nowadays a DASH implementation is required.

rdamas avatar Jan 13 '21 06:01 rdamas

Why would we want to remove it while it still works (By adding --enable-nacl to the chrome command line) and we do not have a better solution?

image

Schimmelreiter avatar Jan 13 '21 07:01 Schimmelreiter

Please note: That doesn't mean I'm against a cleaner/better solution, only against breaking what we have before we have anything better.

Schimmelreiter avatar Jan 13 '21 07:01 Schimmelreiter

How about splitting it off as an installable extension for those who want to keep using it and adding instructions on how to install and run by adding --enable-nacl to the chrome command line? (I had previously gotten it working but couldn't figure out how to on a different machine despite much searching). In fact, as far as I can recall, OpenATV lists OWIF VGX as a separate plugin.

2.3MB per release per image per year for mostly-unknown about functionality would save a huge amount of bandwidth cost!

wedebe avatar Jan 13 '21 12:01 wedebe

That has been implemented as of about day #1 of WebTV/VXG.

https://github.com/oe-alliance/oe-alliance-core/blob/4.4/meta-oe/recipes-oe-alliance/enigma2-plugins/enigma2-plugin-extensions-openwebif.bb#L60-L62

Schimmelreiter avatar Jan 13 '21 13:01 Schimmelreiter

That has been implemented as of about day #1 of WebTV/VXG.

https://github.com/oe-alliance/oe-alliance-core/blob/4.4/meta-oe/recipes-oe-alliance/enigma2-plugins/enigma2-plugin-extensions-openwebif.bb#L60-L62

Perhaps it's just a case of not automatically building public/vxg/.*$', 'enigma2-plugin-%s-vxg *\.pexe$', 'enigma2-plugin-%s-vxg into each enigma image?

wedebe avatar Jan 13 '21 22:01 wedebe

We can also make the split here via travis-ci. And we should not remove it because it's working with "--enable-nacl".

jbleyel avatar Jan 13 '21 23:01 jbleyel

We can also make the split here via travis-ci. And we should not remove it because it's working with "--enable-nacl".

@jbleyel , could you send me a build of the OpenWebif ipk without vxg, please?

There are checks for the vgx pexe filepath, I'll go through some tests to make sure there'll be no crash if the vxg plugin isn't installed by default.

wedebe avatar Jan 17 '21 18:01 wedebe

I will update the build script.

jbleyel avatar Jan 17 '21 19:01 jbleyel

-> https://github.com/E2OpenPlugins/e2openplugin-OpenWebif/tree/gh-pages

jbleyel avatar Jan 17 '21 19:01 jbleyel

Hi @Schimmelreiter ,does --enable-nacl still allow WebTV to run?

According to https://en.wikipedia.org/wiki/Google_Native_Client "Although initially Google planned to remove PNaCl in first quarter of 2018,[8] and later in the second quarter of 2019,[9] it has been removed in June 2022 (together with Chrome Apps).[10][11]"

I've tried it myself, but the "Click here for install plugin" links to https://www.videoexpertsgroup.com/player_start/ ,with no link to a plugin.

wedebe avatar Apr 27 '23 14:04 wedebe