dynamoid icon indicating copy to clipboard operation
dynamoid copied to clipboard

TransactionWrite sanitizes items

Open ckhsponge opened this issue 9 months ago • 1 comments

TransactionWrite should call sanitize_item so that nils are not persisted. Otherwise GSI will fail with a nil range key.

ckhsponge avatar Apr 18 '25 02:04 ckhsponge

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.88%. Comparing base (37572d7) to head (20d2eea). Report is 27 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #897      +/-   ##
==========================================
+ Coverage   91.56%   91.88%   +0.31%     
==========================================
  Files          75       76       +1     
  Lines        3700     3856     +156     
==========================================
+ Hits         3388     3543     +155     
- Misses        312      313       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Apr 18 '25 02:04 codecov[bot]

This was bothering me again today. I'll renew my efforts to fix it.

ckhsponge avatar Aug 28 '25 05:08 ckhsponge

@andrykonchin A review of this would be appreciated. Let me know if you see some areas for cleanup.

ckhsponge avatar Aug 28 '25 17:08 ckhsponge

I'll review this later this week.

andrykonchin avatar Aug 28 '25 19:08 andrykonchin

@andrykonchin Please review again.

ckhsponge avatar Sep 02 '25 19:09 ckhsponge