DynamoRevit icon indicating copy to clipboard operation
DynamoRevit copied to clipboard

[DNM] Remove Dispatcher unhandled exception handler since it's already handled in DynamoCore

Open aparajit-pratap opened this issue 2 years ago • 0 comments

Purpose

This PR depends on https://github.com/DynamoDS/Dynamo/pull/14840 first being merged into Dynamo 3.0.3. If not for 3.0.3, it can wait until the Dynamo PR is merged into 3.1.

~~It skips certain steps in the Dispatcher's unhandled exception handler if the corresponding handler is already invoked in DynamoViewModel.~~

Correction: The Dispatcher's unhandled exception event handler has been moved to DynamoViewModel in https://github.com/DynamoDS/Dynamo/pull/14840. It's no longer needed here.

Declarations

Check these if you believe they are true

  • [ ] The code base is in a better state after this PR
  • [ ] Is documented according to the standards
  • [ ] The level of testing this PR includes is appropriate
  • [ ] User facing strings, if any, are extracted into *.resx files
  • [ ] Snapshot of UI changes, if any.

Reviewers

@pinzart90

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

aparajit-pratap avatar Jan 18 '24 04:01 aparajit-pratap