DynamoRevit icon indicating copy to clipboard operation
DynamoRevit copied to clipboard

Add support to UnwrapElement for marshaling CPython dictionary

Open aparajit-pratap opened this issue 3 years ago • 2 comments

Purpose

https://jira.autodesk.com/browse/DYN-5119 Add support to UnwrapElement for marshaling CPython dictionary

I basically tested the fix with the RC2.15_Revit2023.1 branch based on the Revit version I have installed, which is why I'm making this PR to that branch. I guess this will need to be cherry-picked into master as well.

I'm not sure where to add D4R tests. I remember writing tests for RTF but I don't have the setup anymore nor do I know if that's used anymore. Would need some help here.

Declarations

Check these if you believe they are true

  • [x] The code base is in a better state after this PR
  • [ ] Is documented according to the standards
  • [ ] The level of testing this PR includes is appropriate
  • [ ] User facing strings, if any, are extracted into *.resx files
  • [ ] Snapshot of UI changes, if any.

Reviewers

@mjkkirschner

FYIs

@QilongTang @wangyangshi

aparajit-pratap avatar Aug 18 '22 20:08 aparajit-pratap

do you have any other changes, can I merge it now?

wangyangshi avatar Aug 24 '22 02:08 wangyangshi

add reviewer @ShengxiZhang

wangyangshi avatar Aug 25 '22 05:08 wangyangshi

have merged to master and RC2.16.1_Revit2023

wangyangshi avatar Nov 15 '22 04:11 wangyangshi