Dynamo icon indicating copy to clipboard operation
Dynamo copied to clipboard

DYN-5210: Fix column width in custom selection node when no entries.

Open twastvedt opened this issue 3 years ago • 2 comments

Purpose

Issue Fixed
issue fixed

This PR fixes DYN-5210. When the custom selection node's list is empty, the "Display" and "Value" headers would collapse to a minimum width. Now they stay in the same place.

Declarations

Check these if you believe they are true

  • [x] The code base is in a better state after this PR
  • [x] Is documented according to the standards
  • [x] The level of testing this PR includes is appropriate
  • [x] User facing strings, if any, are extracted into *.resx files
  • [x] All tests pass using the self-service CI.
  • [x] Snapshot of UI changes, if any.

Reviewers

@avidit

twastvedt avatar Sep 23 '22 15:09 twastvedt

@avidit I just saw your note in Jira about preventing deletion of the last list item. I think that makes sense. I'll go ahead and do that and add it here.

twastvedt avatar Sep 23 '22 16:09 twastvedt

OK, now it's ready @avidit!

twastvedt avatar Sep 23 '22 19:09 twastvedt

@avidit what's the status of 2.16.1 - should I cherry pick this into there?

twastvedt avatar Oct 04 '22 14:10 twastvedt

@twastvedt was it supposed to be part of 2.16.1? If yes, please specify early next time. 2.16.1 was released yesterday

QilongTang avatar Oct 04 '22 15:10 QilongTang

nope. Ignore the above. Was not clear on release dates.

twastvedt avatar Oct 04 '22 16:10 twastvedt