Refactor DefaultTokenCreationService

Open stefannikolei opened this issue 5 years ago • 5 comments

Use ValueTask where appropriate
spawn Tasks and await later where appropriate
create a static instance of JsonWebTokenHandler. It does not save any instance data and thus does not need to be created every single time

Jan 06 '21 14:01 stefannikolei

Thanks! We will re-visit when we drop .NET Core 3.1 - i am not a huge fan of ifdefs...

Feb 09 '21 12:02 leastprivilege

If you want I can drop the ifdefs to get the rest in?

Feb 09 '21 13:02 stefannikolei

We switch to target .NET 6 - feel free to update...

Jul 12 '21 06:07 leastprivilege

@leastprivilege i updated it

Jul 12 '21 17:07 stefannikolei

@leastprivilege Did you have a chance to have a look at it. Is there anything I need to tweak?

Nov 02 '21 18:11 stefannikolei

Thanks for this, but we're not in a position to accept this PR. Thanks.

Oct 19 '22 14:10 brockallen