Bee

icon indicating a website link dropdembits.github.io icon indicating an email [email protected]

icon location United States, North America icon location Someone who has some free time (compiler builder [maybe] & other things)

Results 13 comments of Bee

Get rid of mutable syntax node usage

@ShoyuVanilla Have you had the chance to pick this up yet? I'm available to work on this again now that I've got time to do so.

'Convert to manual ...' code action doesn't send the missing members code when snippetTextEdits are disabled

On the match arm that handles when `snippetTextEdits` is unavailable, it ignores whether `impl_def_with_items` is `Some`, which is important since `impl_def_with_items` contains the `impl` with the correct missing members. https://github.com/rust-lang/rust-analyzer/blob/ea7fdada6a0940b239ddbde2048a4d7dac1efe1e/crates/ide-assists/src/handlers/replace_derive_with_manual_impl.rs#L147-L155...

Snippets should allow us to use placeholders

Note that `SourceChangeBuilder` now has `add_placeholder_snippet{_token,_group}`, so now it's just updating the generate assists (e.g. "extract to variable", "extract to function") to use them.