ImageFilter icon indicating copy to clipboard operation
ImageFilter copied to clipboard

Please kindly update for Cordova 3.x. Awesome plugin btw

Open donniemceduns opened this issue 12 years ago • 10 comments

donniemceduns avatar Feb 08 '14 23:02 donniemceduns

1+

Have anyone tried to use Javascript filter like CamanJS to accomplish this?

quanghoc avatar Jun 30 '14 00:06 quanghoc

@quanghoc Yes but with Cordova seems to be really slow (like 15 seconda to apply a filter)

billmn avatar Jul 03 '14 22:07 billmn

@billmn I'm thinking about rewriting CamanJS in an async / non-blocking way. Current bad performance is mostly due to the WebObject. iPhone 5S took about 1-2 sec but still noticable. What I did was to resize the image before processing.

quanghoc avatar Jul 04 '14 07:07 quanghoc

@quanghoc Have you seen this? https://github.com/meltingice/CamanJS/wiki/About-the-block-renderer

billmn avatar Jul 04 '14 08:07 billmn

+1 would love to use this!

travisdahl avatar Aug 07 '14 05:08 travisdahl

@billmn I haven't tested block render. Did it make things faster?

quanghoc avatar Aug 07 '14 06:08 quanghoc

Benefits:

  • Image rendering is asynchronous, which means page rendering is no longer blocked.
  • Slower filters get a nice speed improvement due to (fake) render concurrency. Of course browser JS engines are event-based and single-threaded, but by splitting up the canvas into separate chunks, we give more control to the JS engine for managing operations.

Caman already use this but is really slow yet.

I think the only way to have good performance in image processing is to take advantage of GPU ... therefore need a plugin that allows native access to hardware

billmn avatar Aug 07 '14 06:08 billmn

Before writing this I tried caman and js rendering. The speed and quality will always lack from native.

Sent from my Delorean

On Aug 7, 2014, at 12:41 AM, Davide Bellini [email protected] wrote:

Benefits:

Image rendering is asynchronous, which means page rendering is no longer blocked. Slower filters get a nice speed improvement due to (fake) render concurrency. Of course browser JS engines are event-based and single-threaded, but by splitting up the canvas into separate chunks, we give more control to the JS engine for managing operations. Caman already use this but is really slow yet.

— Reply to this email directly or view it on GitHub.

DrewDahlman avatar Aug 07 '14 06:08 DrewDahlman

Agreed @DrewDahlman . I just tried it, and although its cool for the web it leaves a lot to be desired on the phone. So Drew, from one Dahl-man to another, what are your thoughts on updating this? eh? ;p

travisdahl avatar Aug 07 '14 08:08 travisdahl

any news about updating that

mohamedsalehamin avatar Jul 01 '15 23:07 mohamedsalehamin