modmailbot icon indicating copy to clipboard operation
modmailbot copied to clipboard

Fix typingProxy + Add some features

Open Akinator31 opened this issue 1 year ago • 4 comments

I fixed an issue with the TypingProxy module that just wasn't working at all. The problem was that the "if" which checks that typingProxy is enabled in the config file, was trying to check that the "channel" parameter was an instance of the Eris PrivateChannel class. However, it always returned False due to a problem in Eris's code.

if (config.typingProxy && (channel instanceof Eris.PrivateChannel) TO if (config.typingProxy && !(channel instanceof Eris.GuildChannel))

To solve this problem, I simply checked that the "channel" was not a server message and it worked.

Akinator31 avatar May 27 '24 13:05 Akinator31

You should create separate PRs for different features

rubyowo avatar May 28 '24 14:05 rubyowo

Yes but I have to create different fork..

Akinator31 avatar May 28 '24 15:05 Akinator31

Yes but I have to create different fork..

No you don't! You need to create different branches. Normally master (or main, but master in this case) is preserved with new branches deriving from that. Realistically, if you want to get this merged, you will make life easy for the maintainers and make separate PRs for different features.

I don't know your exact setup but it looks like you're trying to merge your master. I would suggest making a new branch from your latest commit, stashing the secondary features, and then editing your PR to reflect this. You can use these stashed commits to form their own branches, which should become PRs in their own right.

zayKenyon avatar Jun 13 '24 08:06 zayKenyon

Oh yes, you're right, I'll do that. Thanks for the tip ;)

Akinator31 avatar Jun 13 '24 09:06 Akinator31

Thank you, the documentation in #806 is great!

zayKenyon avatar Jul 05 '24 15:07 zayKenyon

Thank you ;)

Akinator31 avatar Jul 05 '24 16:07 Akinator31