sipml5 Ice gathering timeout, 10 seconds delay

We have a problem: if a user has several network interfaces or if user's NAT is very strange: in such cases the ICE Gathering can take 10 seconds on outgoing calls. This is not good. I added a very simple hack: to stop gathering after 2 seconds after first candidate appeared. We can have a look at this hack here a1fae10b5b52460f4cb5fd14315bfe24cd22cd57 I am not good in sipml5 architecture, but I think that such timeout should be tunable via sipStack creation (like in sipjs).

Dec 13 '15 01:12 roginvs

I agree, it should be tunable.

Jan 07 '16 13:01 vfontes

Good point thank you

Mar 03 '16 20:03 garronej

Does this change not break anything under any circumstances?

Mar 09 '16 10:03 ackvf

@vferko , I am not sure. But we are using this hack for almost two months, and everything is still fine.

Mar 09 '16 11:03 roginvs

@roginvs, thank you, this is enough for me. I assume this file (roginvs/sipml5/release/SIPml-api.js) implements the proposed changes..

Mar 09 '16 11:03 ackvf

@vferko, yes, everything is right, this link holds sipml5 with this change + patch for Chrome workaround.

Mar 09 '16 11:03 roginvs

when i use that solution in my app, some times attended transfer getting one way audio.

Mar 13 '19 18:03 viniciusstroher

very thank you

Jan 10 '20 02:01 SeiKiMo