typist icon indicating copy to clipboard operation
typist copied to clipboard

feat: Add `RichTextVideo` extension for video playback

Open rfgamaral opened this issue 2 years ago • 1 comments

Overview

This adds a Video extension to Typist, which is very similar to the one that we have for Images - but for Videos - and parts of the code (mostly related to the uploading mechanism) have been copy-pasted.

Although this was built to be used as an example for a presentation where I go through the steps of building a Typist extension, this could be very well considered ready for prime time. There might be a thing or two that we might want to change and/or do differently, but other than that, the code is pretty much production-ready. However, this will be a draft PR until we are sure that we want to include such extension in our products.

PR Checklist

Test plan

  • Open the preview Storybook deployed to Netlify
  • Open the Rich-text → Default story
    • [ ] Smoke test the Video extension and make sure it works as you'd expect it to

rfgamaral avatar Apr 11 '24 09:04 rfgamaral

Deploy Preview for doist-typist ready!

Name Link
Latest commit d5325b9f7f938a77716a875d8d93a7a26eef3867
Latest deploy log https://app.netlify.com/sites/doist-typist/deploys/6617acbbab75b10008aa1bf4
Deploy Preview https://deploy-preview-735--doist-typist.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 11 '24 09:04 netlify[bot]