python-timezones icon indicating copy to clipboard operation
python-timezones copied to clipboard

Add test for obsolete names

Open goncalossilva opened this issue 2 years ago • 5 comments

While working on #40, I noticed we use several obsolete timezone names:

python-timezones – _defs py 2023-10-04 at 11 39 49 AM

For example, most of those Europe/ should either be Europe/Brussels or Europe/Prague according to IANA.

On the one hand, I'm concerned about how much we're falling behind. E.g., it's been a long while since America/Godthab has been replaced with America/Nuuk.

On the other hand, if we follow IANA's deprecations, we'll greatly simplify our list, but we may lose some user-friendliness. E.g., Europe/Copenhagen is obsolete in favor of Europe/Berlin and would be completely gone. Is that OK?

Thoughts @amix?

goncalossilva avatar Oct 04 '23 10:10 goncalossilva

Thoughts @amix?

It was many years ago I looked into this. I don't have any strong opinions here; we should follow the current best practices 😊

amix avatar Oct 04 '23 12:10 amix

I wish I knew what “best practices” are in this context. 😅 My instinct is to follow IANA, but the whole debate about timezones doesn't feel very user-friendly in general.

Europe/Copenhagen is obsolete in favor of Europe/Berlin and would be completely gone. Is that OK?

How would you feel about this, as a user?

goncalossilva avatar Oct 04 '23 12:10 goncalossilva

Europe/Copenhagen is obsolete in favor of Europe/Berlin and would be completely gone. Is that OK? How would you feel about this, as a user?

I would not care a lot, I think. Most Europeans are probably very timezone aware, and it would be easy to pick a city that's in the same timezone 🤔

amix avatar Oct 05 '23 12:10 amix

In that case, I wonder if we should stop hard-coding a list of these ourselves and simply use IANA's of current defaults (minus deprecations). In other words, to generate these at runtime. I'll mention this in a team meeting, I may be missing something.

goncalossilva avatar Oct 07 '23 02:10 goncalossilva

Could make sense, @goncalossilva! 👌

amix avatar Oct 09 '23 09:10 amix