Parser icon indicating copy to clipboard operation
Parser copied to clipboard

.parse not working as expected (unit tests fail)

Open ahx opened this issue 10 years ago • 7 comments

The unit tests added in https://github.com/DSSWG/DSS/pull/66 are failing.

ahx avatar May 19 '15 09:05 ahx

Me and @mbrendler just figured out that the bug was introduced in https://github.com/DSSWG/DSS/commit/c0e27bf7a130b61bb10ea4364ad0c373d6bd5b3b, we are taking a deeper look at this right now. Ping here, if you have any thoughts.

ahx avatar Jun 04 '15 09:06 ahx

#69 fixes this for multiline comments that look like:

/*
* @name Foo
*/

…but it still fails for a syntax like mentioned in the README:

//
// @name Foo
//

ahx avatar Jun 04 '15 14:06 ahx

Do you have plans how to solve this?

ahx avatar Jun 19 '15 09:06 ahx

@ahx Yep. I had a fix in the works about 2 weeks ago. I'll try and push that up this weekend. Definitely ping me again if you don't see any activity by Monday morning

darcyclarke avatar Jun 19 '15 15:06 darcyclarke

Ping @darcyclarke :heart: :tulip: :fireworks: :tokyo_tower:

ahx avatar Jun 23 '15 08:06 ahx

ping @darcyclarke :smiley:

ygd avatar Jul 07 '15 03:07 ygd

This project has become pretty stale. – Do you think #68 should be done before trying to solve this within the current implementation?

ahx avatar Oct 29 '15 12:10 ahx