Sovryn-frontend icon indicating copy to clipboard operation
Sovryn-frontend copied to clipboard

charting-library still in master_external

Open Mik13 opened this issue 3 years ago • 7 comments

https://github.com/DistributedCollective/Sovryn-frontend/blob/a247f04a071b0495b7fb45427f79919aaf4d5618/package.json#L9

The package seems to be deleted: https://www.npmjs.com/package/@distributedcollective/charting-library

Mik13 avatar Mar 14 '22 16:03 Mik13

The trading view license does not allow us to publish their code. See https://github.com/DistributedCollective/Sovryn-frontend#external-contributors for more information. There you can find information on how to work as an external contributor with the code base.

Sorry for the inconvenience. We are not happy with this either.

ShynRou avatar Mar 15 '22 08:03 ShynRou

I understand, but it's out of our hands I guess.

Anyway, sorry to disturb again, but it looks like this package is also in the master_external branch, where it shouldn't according to the docs. The development_external is correct.

Mik13 avatar Mar 17 '22 13:03 Mik13

@soulBit please investigate.

ShynRou avatar Mar 17 '22 13:03 ShynRou

There has been no activity on this issue for two months. It will be closed in a week if no further activity occurs. If you would like to move this issue forward, please respond to any outstanding feedback.

github-actions[bot] avatar May 17 '22 10:05 github-actions[bot]

There has been no activity on this issue for two months. It will be closed in a week if no further activity occurs. If you would like to move this issue forward, please respond to any outstanding feedback.

I don't think there is outstading feedback, please do not close.

Mik13 avatar May 17 '22 15:05 Mik13

There has been no activity on this issue for two months. It will be closed in a week if no further activity occurs. If you would like to move this issue forward, please respond to any outstanding feedback.

github-actions[bot] avatar Jul 18 '22 10:07 github-actions[bot]

Still the same.

@soulBit Any roadmap?

Mik13 avatar Jul 19 '22 04:07 Mik13

There has been no activity on this issue for two months. It will be closed in a week if no further activity occurs. If you would like to move this issue forward, please respond to any outstanding feedback.

github-actions[bot] avatar Sep 18 '22 10:09 github-actions[bot]

@ShynRou @soulBit this makes me quite sad, I really love the project, but this is a horrible experience here.

Mik13 avatar Sep 18 '22 16:09 Mik13

@Mik13, please use "@sovryn/charting-library" and "master" instead "master_external" branch

creed-victor avatar Sep 19 '22 06:09 creed-victor