disnake icon indicating copy to clipboard operation
disnake copied to clipboard
verified publisher icon DisnakeDev

feat: implement `voice_channel_effect` event

Open shiftinv opened this issue 2 years ago • 3 comments

Summary

https://github.com/discord/discord-api-docs/pull/6025

Unresolved Issues

  • There are a couple TODOs that could use some discussion, mostly regarding design.
  • ~~I couldn't decide where to put VoiceChannelEffect, so for now it lives in disnake.raw_models - probably not the best location though, would appreciate other ideas.~~

Checklist

  • [x] If code changes were made, then they have been tested
    • [x] I have updated the documentation to reflect the changes
    • [x] I have formatted the code properly by running pdm lint
    • [x] I have type-checked the code by running pdm pyright
  • [ ] This PR fixes an issue
  • [x] This PR adds something new (e.g. new method or parameters)
  • [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • [ ] This PR is not a code change (e.g. documentation, README, ...)

shiftinv avatar Mar 30 '23 14:03 shiftinv

@shiftinv would you please resolve conflicts?

onerandomusername avatar Apr 08 '23 19:04 onerandomusername

Do we need to wait on the docs PR for this? I'm not quite sure if they plan to ever merge it.

onerandomusername avatar May 02 '23 16:05 onerandomusername

Probably, yea. It's not that important of a feature anyway, so personally I'm fine with waiting a little longer.

shiftinv avatar May 02 '23 22:05 shiftinv