disnake icon indicating copy to clipboard operation
disnake copied to clipboard

Interactions should use `connector`, `proxy`, `proxy_auth` kwargs of client

Open shiftinv opened this issue 4 years ago • 0 comments

Summary

Since interaction responses are webhooks and as such don't go through http.py but instead through async_.py, the connector/proxy/proxy_auth kwargs passed to Client.__init__ don't apply.

Expected Results

interaction callbacks go through the proxy and/or use the specified connector

Actual Results

they don't

Intents

all

System Information

latest / 2025dfbd17cc81e97ff9cf46e945c36848f34054

Checklist

  • [X] I have searched the open issues for duplicates.
  • [X] I have shown the entire traceback, if possible.
  • [X] I have removed my token from display, if visible.

Additional Context

Not only does this prevent interactions from working in configurations where a proxy is absolutely required, it's also a bit annoying when debugging HTTP reqs. The past few weeks I resorted to monkeypatching bot.http._HTTPClient__session._request, but I'm sure anyone would agree that this isn't a great solution, so it's time to change that :^)

shiftinv avatar Jan 08 '22 14:01 shiftinv