MovieSwiftUI icon indicating copy to clipboard operation
MovieSwiftUI copied to clipboard

Issue-76-78: Genre & People Detail Bugs

Open glnygl opened this issue 2 years ago • 4 comments

Issue-76: NavigationLink without destination code fixed that issue

Simulator Screen Recording - iPhone 15 Pro - 2024-01-16 at 12 49 59

Issue-78: Remove animations fixed that issue

Simulator Screen Recording - iPhone 15 Pro - 2024-01-17 at 18 29 17

  • Fixed thread warning

glnygl avatar Jan 16 '24 09:01 glnygl

Hello everybody, first of all, congratulations for this really great project.. same issue when you are in the Genres list, you have the list of films according to genre but as soon as you click on a film it returns to the list of films of the Genre. Same when you are looking for a Film with a comment, as soon as you click on the comment it is not displayed and returns to the FILM detail page. I hope my descriptions of the bugs isn't confusing and that this hasn't already been covered. Ogun

Kiyzer avatar Feb 04 '24 18:02 Kiyzer

Hello everybody, first of all, congratulations for this really great project.. same issue when you are in the Genres list, you have the list of films according to genre but as soon as you click on a film it returns to the list of films of the Genre. Same when you are looking for a Film with a comment, as soon as you click on the comment it is not displayed and returns to the FILM detail page. I hope my descriptions of the bugs isn't confusing and that this hasn't already been covered. Ogun

Hi Ogun, I think I fixed these bugs that you mentioned with this pr. This pop back problem is caused by different navigation code. You can also check this fix in your simulator. If still there is a problem maybe you can add a screetshot of video.

glnygl avatar Feb 04 '24 21:02 glnygl

@glnygl Hi, Gülenay, yes I see your corrections and did . It solved the bugs in Genres Navigations in de Movie details and the cast details but it seems persist when you are in genres List and Review.

https://github.com/Dimillian/MovieSwiftUI/assets/96753216/e0dedfb1-abec-4bcb-9c7d-fa35895a6749

and the same issue when you tap on Reviews. I see the same bug when you create a custom list, and you want to check the movie details pop back Ogün ;)

Kiyzer avatar Feb 04 '24 22:02 Kiyzer

@glnygl Hi, Gülenay, yes I see your corrections and did . It solved the bugs in Genres Navigations in de Movie details and the cast details but it seems persist when you are in genres List and Review.

RPReplay_Final1707084577.MP4 and the same issue when you tap on Reviews. I see the same bug when you create a custom list, and you want to check the movie details pop back Ogün ;)

Hi Ogun, now i see the problem. Video helped a lot thanks for this. After debug I realized that there is a problem in store. When I comment out "fetchMovieDetails" func in MovieDetail view it works properly. But i didn't understand why dispatch func cause this problem. Im still on it. If you find a way to solve this bug please inform me. Im really curious about it. 😅

glnygl avatar Feb 05 '24 11:02 glnygl