IceCubesApp icon indicating copy to clipboard operation
IceCubesApp copied to clipboard

Timeline: restore the selected timeline at the next startup

Open mofmofmofneko opened this issue 3 years ago • 2 comments

Closes: #581

mofmofmofneko avatar Feb 07 '23 07:02 mofmofmofneko

I think you need to rebase on main one more time, missing the remoteLocal new filter parameter. It create when switching account for example, if you saved a list not available on the other account etc... And it'll also fail whenever I'll add new filters (but I guess this is fine). Also have to test the various login / logout configuration.

I just think it's a lot of effort for such a small feature, and it could create unforeseen issues. Multi accounts being a problem right now with this feature.

Dimillian avatar Feb 07 '23 07:02 Dimillian

I will fix that. Thank you!

mofmofmofneko avatar Feb 07 '23 07:02 mofmofmofneko

@Dimillian Regarding the account switch problem that you are concerned about, it is a little overbearing, but how about saving the state by limiting it to the tabs common to the account as follows?

    .onChange(of: timeline) { timeline in
      if(timeline == .home || timeline == .federated || timeline == .local) {
        lastTimelineFilter = timeline
      }
    }

mofmofmofneko avatar Feb 09 '23 09:02 mofmofmofneko

@nekolaboratory Sound good. Unless it really break the feature as you would use it.

Dimillian avatar Feb 09 '23 09:02 Dimillian

Thank you. Changes have already been committed.

mofmofmofneko avatar Feb 09 '23 10:02 mofmofmofneko

Thanks! Let's give it a try!

Dimillian avatar Feb 09 '23 11:02 Dimillian

Cheers! On the Mastodon instance I'm based on, the local timeline is mainstream. So being able to record the default timeline is a very useful feature.

Can't wait for the release!

mofmofmofneko avatar Feb 09 '23 12:02 mofmofmofneko