IceCubesApp icon indicating copy to clipboard operation
IceCubesApp copied to clipboard

Setting to hide boost content

Open jdanthinne opened this issue 3 years ago • 7 comments

For users who prefers only original content (without boosts), this adds a setting to hide the boosts content in the timeline, with a button to reveal it.

Simulator Screen Recording - iPhone 14 Pro - 2023-01-22 at 13 53 27

jdanthinne avatar Jan 22 '23 12:01 jdanthinne

Interesting how it shows the toot but hides the content. I’ve been meaning to suggest a feature to filter out toots based on content. E.g. if I follow someone for their tech content but don’t want to see their sports content or whatever.

This kind of UI might be good for that too. I’m sure it’d avoid a lot of complexity that you’d run into if you tried to hide those toots altogether.

henrik avatar Jan 22 '23 14:01 henrik

I'm not 100% sure we'll want it like that. If the goal is to hide the content, it could literally return EmptyView() instead of the status? But even there we could have some side effects.

Dimillian avatar Jan 22 '23 15:01 Dimillian

In fact I was hesitating between hiding the content (as provided) and completely removing the posts from the list (globally or per user).

jdanthinne avatar Jan 22 '23 15:01 jdanthinne

How would this relate to Mastodon's built-in "hide boosts" feature?

patrickhoefler avatar Jan 22 '23 17:01 patrickhoefler

Yeah, side effects from returning an empty view could be stuff like saying “2 new posts” but only showing 1, or showing none, etc.

henrik avatar Jan 22 '23 17:01 henrik

Yeah, side effects from returning an empty view could be stuff like saying “2 new posts” but only showing 1, or showing none, etc.

If the choice is to completely hide boosts, I wouldn't do that with EmptyView but by filtering the data source instead.

jdanthinne avatar Jan 22 '23 17:01 jdanthinne

Make sense but TimelineViewModel is far from simple and probably time for a refactor if we need to inject user settings on top of that. But sound good to filter at the datasource level.

Dimillian avatar Jan 22 '23 17:01 Dimillian

How would this relate to Mastodon's built-in "hide boosts" feature?

You're right! This is already built-in with Mastodon API, on a per-user basis. I'll try it use that.

jdanthinne avatar Jan 22 '23 18:01 jdanthinne

The "API way" is here: https://github.com/Dimillian/IceCubesApp/pull/305

jdanthinne avatar Jan 23 '23 11:01 jdanthinne