Maskbook icon indicating copy to clipboard operation
Maskbook copied to clipboard

feat: Integrate KardiaChain Network

Open AJackTi opened this issue 3 years ago • 5 comments

Description

Closes # (NO_ISSUE)

Type of change

  • [ ] Documentation
  • [ ] Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • [x] My code follows the style guidelines of this project.
  • [x] I have performed a self-review of my own code.
    • [x] I have removed all in development console.logs
    • [x] I have removed all commented code.
  • [x] I have commented on my code, particularly in hard-to-understand areas.
  • [x] I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • [x] I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • [x] I have delegated all web requests to the background service via the internal RPC bridge.

AJackTi avatar Mar 30 '22 10:03 AJackTi

CC @DimensionDev/dev-smartcontract Please deploy our contracts on KaradiaChain.

guanbinrui avatar Apr 06 '22 04:04 guanbinrui

CC @DimensionDev/dev-smartcontract Please deploy our contracts on KaradiaChain.

OK. I'll deploy contracts on the new chain later.

SpaceStation09 avatar Apr 06 '22 04:04 SpaceStation09

Screen Shot 2022-04-06 at 3 15 00 PM

Sorry but I have a question, why are those files conflicted? We just added Kardiachain network into each file.

peihsendoyle avatar Apr 06 '22 08:04 peihsendoyle

Hi @AjackTi, Please add me as a collaborator of you cloned repo. I got some configuration stuff need to update.

guanbinrui avatar Apr 20 '22 03:04 guanbinrui

@DimensionDev/qa

guanbinrui avatar Apr 22 '22 05:04 guanbinrui

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 08 '22 19:09 stale[bot]