dice icon indicating copy to clipboard operation
dice copied to clipboard

Inconsistent `BITCOUNT`: BITCOUNT syntax error #1

Open lucifercr07 opened this issue 1 year ago • 7 comments

Steps to reproduce

Run the commands mentioned in the test on Line 133 in the file https://github.com/AshwinKul28/dice-tests/blob/main/tcltests/unit/bitpos.tcl#L133

Expected output

The expected output when the above set of commands when run on Redis

'ERR *syntax*'

Observed output

The observed output when the above set of commands when run on DiceDB

'26'

The steps to run the test cases are mentioned in the README of the dice-tests repository.

Expectations for resolution

This issue will be considered resolved when the following things are done:

  1. Changes in the dice repository code to meet the expected behavior.
  2. Successful run of the tcl test behavior.

You can find the tests under the tests directory of the dice repository and the steps to run are in the README file. Refer to the following links to set up DiceDB and Redis 7.2.5 locally

lucifercr07 avatar Sep 20 '24 18:09 lucifercr07

Hi @lucifercr07 , can you assign this task to me?

Nijin-P-S avatar Sep 21 '24 04:09 Nijin-P-S

Hi @lucifercr07 Can I take this up ? Would love to work on it. Thanks

jainbhavya53 avatar Sep 21 '24 09:09 jainbhavya53

@Nijin-P-S @jainbhavya53 Assigned other issues to both of you. Let's have a single issue on your plate at a time. Once that's completed you can pick other opened issues.

AshwinKul28 avatar Sep 21 '24 10:09 AshwinKul28

@AshwinKul28 please assign this to me

shardul08 avatar Sep 21 '24 14:09 shardul08

@shardul08 assigned, thanks for contributing.

lucifercr07 avatar Sep 21 '24 15:09 lucifercr07

Fixed by #699

shardul08 avatar Sep 24 '24 19:09 shardul08

Hello @shardul08,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

arpitbbhayani avatar Oct 03 '24 14:10 arpitbbhayani

Closing, fixed as part of https://github.com/DiceDB/dice/pull/699

lucifercr07 avatar Oct 06 '24 12:10 lucifercr07