dice icon indicating copy to clipboard operation
dice copied to clipboard

Add support for command `BITFIELD_RO`

Open arpitbbhayani opened this issue 1 year ago • 12 comments

Add support for the BITFIELD_RO command in DiceDB similar to the BITFIELD_RO command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

arpitbbhayani avatar Sep 20 '24 17:09 arpitbbhayani

@arpitbbhayani i would like to work on this, can you please assign to me?

kushal0511-not avatar Sep 20 '24 18:09 kushal0511-not

@kushal0511-not Thanks for taking this up. assigned.

arpitbbhayani avatar Sep 20 '24 18:09 arpitbbhayani

hi @kushal0511-not, are you still working on this issue? If not, Can I pick this up?

anchalsinghrajput avatar Sep 25 '24 18:09 anchalsinghrajput

@anchalsinghrajput i am waiting for #639 to complete , this command will use that command only.

kushal0511-not avatar Sep 25 '24 18:09 kushal0511-not

Hi @kushal0511-not , #639 is in progress and will need some time to ensure I handle all the edge cases for all 4 subcommands. Thanks.

apoorvyadav1111 avatar Sep 25 '24 18:09 apoorvyadav1111

Hi @kushal0511-not , I have created a PR #723 for #639. However, It is still a draft so more changes might come upon further testing. Apoorv

apoorvyadav1111 avatar Sep 26 '24 01:09 apoorvyadav1111

@apoorvyadav1111 Thanks for informing. I will take a look.

kushal0511-not avatar Sep 26 '24 02:09 kushal0511-not

@JyotinderSingh I’m currently occupied with other work commitments and won’t be able to work on this. Feel free to assign someone else. Thanks.

kushal0511-not avatar Sep 27 '24 08:09 kushal0511-not

Hey @JyotinderSingh , will get this done since Kushal has unassigned himself. Please assign to me!

iamskp11 avatar Sep 27 '24 10:09 iamskp11

Hey @JyotinderSingh , will get this done since Kushal has unassigned himself. Please assign to me!

Assigned

JyotinderSingh avatar Sep 27 '24 10:09 JyotinderSingh

Just an update. Have implemented the methods, and added tests. Will be raising PR, post adding some more tests.

iamskp11 avatar Sep 30 '24 15:09 iamskp11

Hi @iamskp11, bitfield has been implemented. This issue was tagged as dependent on the bitfield command, so just wanted to share update here.

apoorvyadav1111 avatar Oct 04 '24 16:10 apoorvyadav1111