dice icon indicating copy to clipboard operation
dice copied to clipboard
verified publisher icon DiceDB

#498: Add support for JSON.OBJKEYS

Open iamskp11 opened this issue 1 year ago • 2 comments

Issue

Issue fixed : https://github.com/DiceDB/dice/issues/498

PR Description

This PR implements JSON.OBJKEYS command, and add unit tests, integration tests and benchmarking evaluation for the command.

Test Results

  1. Dice DB vs Redis 127 0 0 17379 Dice DB CLI usage

127 0 0 16379 json objkeys doc Redis CLI usage

  1. Unit Tests Pasted Graphic 3 Pasted Graphic 4

  2. Integration Tests Pasted Graphic 2

  3. Benchmarking Pasted Graphic 5

iamskp11 avatar Sep 19 '24 19:09 iamskp11

Hey @lucifercr07 @JyotinderSingh @jujiale , requesting for your reviews on this PR.

iamskp11 avatar Sep 19 '24 19:09 iamskp11

thanks for your contribution. this command logic looks well. I left a few comments. please have a look. thanks

jujiale avatar Sep 20 '24 01:09 jujiale

thanks for your contribution. this command logic looks well. I left a few comments. please have a look. thanks

Addressed all comments in this commit

iamskp11 avatar Sep 20 '24 07:09 iamskp11

Hey @JyotinderSingh @lucifercr07 , requesting you to have a look and review this PR. Have addressed initial reviews.

iamskp11 avatar Sep 21 '24 15:09 iamskp11

@iamskp11 please take these changes up. Let's maintain high bar of quality

Hey @manishrw Thanks for reviewing! Have responded to one of the comment, please have a look and tell your views. Next, I will be creating a new PR with your suggested changes.

iamskp11 avatar Sep 25 '24 16:09 iamskp11