dice icon indicating copy to clipboard operation
dice copied to clipboard

Add support for Redis `TYPE` command

Open JyotinderSingh opened this issue 1 year ago • 5 comments

Add support for the TYPE command in DiceDB similar to the TYPE command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

JyotinderSingh avatar Sep 13 '24 17:09 JyotinderSingh

Kindly assign this task to me

rishirishhh avatar Sep 13 '24 17:09 rishirishhh

Kindly assign this task to me

Assigned.

JyotinderSingh avatar Sep 13 '24 17:09 JyotinderSingh

@rishirishhh are you working on it.

Gauravkumar2701 avatar Sep 16 '24 13:09 Gauravkumar2701

yes I am

rishirishhh avatar Sep 16 '24 15:09 rishirishhh

I will be completing the issue in next 2 days

rishirishhh avatar Sep 16 '24 22:09 rishirishhh

Merged as part of https://github.com/DiceDB/dice/pull/601

lucifercr07 avatar Sep 19 '24 13:09 lucifercr07