dice icon indicating copy to clipboard operation
dice copied to clipboard
verified publisher icon DiceDB

Add Support for JSON.INGEST Command in RESP Protocol

Open pratikpandey21 opened this issue 1 year ago • 8 comments

Description

Extend support for the JSON.INGEST command to the RESP (REdis Serialization Protocol) format. This command allows users to set a value based on a dynamically generated key, where the key is generated using a key prefix and a unique identifier. The key prefix will be provided as an argument in the RESP command.

Command Overview:

Command: JSON.INGEST Example: JSON.INGEST <key_prefix> <JSON_value> Functionality: This command functions like the SET command, but instead of specifying a full key, the user provides a key prefix. The full key is generated by appending a unique identifier to the key prefix, and the provided JSON value is stored against this generated key.

Details:

The command will act like the existing SET command, where:

  • key_prefix is the prefix of the key that the user wants to use.
  • JSON_value is the value to be stored in JSON format.

The complete key is dynamically generated by appending a unique identifier to the provided key prefix.

Tasks:

  • Implement the JSON.INGEST command support in RESP.
  • Create comprehensive documentation in DiceDB Docs for the JSON.INGEST command in RESP, including usage examples, parameter descriptions, and potential use cases.

pratikpandey21 avatar Sep 12 '24 14:09 pratikpandey21

Depends On: https://github.com/DiceDB/dice/issues/551

pratikpandey21 avatar Sep 12 '24 14:09 pratikpandey21

I would like to work on this issue if its not assigned to anyone @arpitbbhayani

rishirishhh avatar Sep 12 '24 16:09 rishirishhh

@rishirishhh thanks for contributing, assigned.

lucifercr07 avatar Sep 12 '24 18:09 lucifercr07

Hi @lucifercr07 can 2 people collaborate on the same issue?

bhagatvansh avatar Sep 12 '24 18:09 bhagatvansh

@lucifercr07 This issue as mentioned by you depends on #551 , so I will have to wait for a PR that resolves that issue first then only dive into working on this issue right?

rishirishhh avatar Sep 12 '24 19:09 rishirishhh

@rishirishhh you can collaborate with @kushal0511-not on #551.

lucifercr07 avatar Sep 13 '24 04:09 lucifercr07

Dependednt PR merged as part of https://github.com/DiceDB/dice/pull/588. @rishirishhh please let us know if you're blocked on this.

lucifercr07 avatar Sep 19 '24 13:09 lucifercr07

@rishirishhh any updates from your side, please let us know if any blockers.

pratikpandey21 avatar Sep 19 '24 20:09 pratikpandey21

@rishirishhh any updates from your side, please let us know if any blockers.

pratikpandey21 avatar Sep 20 '24 18:09 pratikpandey21

@pratikpandey21 - I think this is done in #551.

psrvere avatar Sep 23 '24 23:09 psrvere

Closing as merged as part of PR. cc: @pratikpandey21

lucifercr07 avatar Sep 24 '24 04:09 lucifercr07