dice icon indicating copy to clipboard operation
dice copied to clipboard

Add support for command `JSON.OBJLEN`

Open arpitbbhayani opened this issue 1 year ago • 6 comments

Add support for the JSON.OBJLEN command in DiceDB similar to the JSON.OBJLEN command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

arpitbbhayani avatar Sep 08 '24 18:09 arpitbbhayani

Assign this issue to me. Thanks

rushabhk04 avatar Sep 09 '24 03:09 rushabhk04

@rushabhk04 assigned, thanks for picking this up.

lucifercr07 avatar Sep 09 '24 04:09 lucifercr07

Hey @lucifercr07 @rushabhk04 , Since there are no updates here since 5 days, is this still being worked on? Will be happy to work on this

iamskp11 avatar Sep 14 '24 06:09 iamskp11

Yes, please go ahead with it. Thanks

rushabhk04 avatar Sep 15 '24 06:09 rushabhk04

Hey @lucifercr07 , have picked this one, and have done basic method implementation. Will be sharing PR post tests and benchmarking memory + time. Thanks!

iamskp11 avatar Sep 15 '24 15:09 iamskp11

Hey @iamskp11 , i'm really sorry didn't notice that you are also working on it , since this issue was inactive i just started working on and created a PR for it.Sorry! @lucifercr07 could you please review the PR,thanks.

phaneesh707 avatar Sep 15 '24 20:09 phaneesh707