DiceDB
Add support for command `JSON.NUMMULTBY`
Add support for the JSON.NUMMULTBY command in DiceDB similar to the JSON.NUMMULTBY command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.
Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.
For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.
@arpitbbhayani. Could you please assign this to me? I would like to work on it.
Hi @lucifercr07 @c-harish Is this still being worked upon ? Otherwise I'll be happy to pick this up. Thanks
Also, this command has been deprecated here, do we still want to support it ? https://redis.io/docs/latest/commands/json.nummultby/
Hi @lucifercr07 @c-harish Is this still being worked upon ? Otherwise I'll be happy to pick this up. Thanks
Hi @jainbhavya53. I am done with the eval func and yet to complete the unit tests. I will raise PR before tomorrow.
Hello @c-harish,
There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.
We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.
Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.
Thanks again.
Hello @c-harish,
There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.
We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.
Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.
Thanks again.
Hi @arpitbbhayani Have raised PR #592. Added support for JSON.NUMMULTBY command, unit tests and integration tests. Waiting for review from maintainers.
Thanks.
