dice icon indicating copy to clipboard operation
dice copied to clipboard

Add support for command `JSON.ARRTRIM`

Open arpitbbhayani opened this issue 1 year ago • 4 comments

Add support for the JSON.ARRTRIM command in DiceDB similar to the JSON.ARRTRIM command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

arpitbbhayani avatar Sep 08 '24 18:09 arpitbbhayani

@jujiale since you've extensively helped support JSON features in DiceDB so far, would you like to take this issue up?

JyotinderSingh avatar Sep 08 '24 19:09 JyotinderSingh

@jujiale since you've extensively helped support JSON features in DiceDB so far, would you like to take this issue up?

sure.please assign to me. thanks.

jujiale avatar Sep 09 '24 01:09 jujiale

Hi @lucifercr07 @jujiale Is this still being worked upon ? Otherwise I'll be happy to pick this up. Thanks

jainbhavya53 avatar Sep 15 '24 08:09 jainbhavya53

Hi @lucifercr07 @jujiale Is this still being worked upon ? Otherwise I'll be happy to pick this up. Thanks

yes. processing

jujiale avatar Sep 17 '24 15:09 jujiale

Hello @jujiale,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

arpitbbhayani avatar Oct 03 '24 14:10 arpitbbhayani

Closing, merged as part of https://github.com/DiceDB/dice/pull/769

lucifercr07 avatar Oct 03 '24 16:10 lucifercr07