DiceDB
Add support for command `JSON.ARRINDEX`
Add support for the JSON.ARRINDEX command in DiceDB similar to the JSON.ARRINDEX command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.
Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.
For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.
@jujiale I believe you already have a few issues assigned (https://github.com/DiceDB/dice/issues/484, https://github.com/DiceDB/dice/issues/487, https://github.com/DiceDB/dice/issues/489, https://github.com/DiceDB/dice/issues/490, https://github.com/DiceDB/dice/issues/503). Once you wrap those up, you’re welcome to pick this one. Want to make sure everyone gets a chance to contribute :) Thanks so much for your eagerness and enthusiasm.
@jujiale I believe you already have a few issues assigned (#484, #487, #489, #490, #503). Once you wrap those up, you’re welcome to pick this one. Want to make sure everyone gets a chance to contribute :) Thanks so much for your eagerness and enthusiasm.
ok, let's build dice stronger together
Hi @lucifercr07 Is this still being worked upon ? Otherwise I'll be happy to pick this up. Thanks
[Update]: still working on this, implementation almost done, working on adding test cases
Hello @Rits1272,
There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.
We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.
Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.
Thanks again.
I have opened PR for this already. There are some reviews/comments on the PR. I will resolve it in a day or two
Hello @Rits1272,
There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.
We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.
Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.
Thanks again.
This issue is available since there has been no activity on the associated PR (#765) for a while. Anyone interested in picking this up can refer to the existing PR and its review comments.
Hi @JyotinderSingh - would like to take this on next! Please assign to me whenever possible
Hi @JyotinderSingh - would like to take this on next! Please assign to me whenever possible
Assigned
Update 10/24 - had some work commitments, sorry for the delay. I have started working on the implementation a couple of days back, referred the prior PR and suggestions in there. Will try to link a draft / ready PR by EOW.
cc @JyotinderSingh
Hi @sashpawar11 , How are you? I am excited to know about your progress so far.
Hi @apoorvyadav1111 @JyotinderSingh - I'm not able to work on this at the moment due to work priorities. Sorry for the inconvenience and delay caused - please assign out to someone else.
Thankyou
