dice icon indicating copy to clipboard operation
dice copied to clipboard

Inconsistent `GETDEL`: returns (nil) for data created by setbit

Open apoorvyadav1111 opened this issue 1 year ago • 4 comments

The command GETDEL is not consistent with Redis implementation. Here are the steps to reproduce the issue

setbit a 1 1
get a
getdel a
get a 

Here's the output I observed in Redis v7.2.5

image

and here's the output I observed in DiceDB's latest commit of the master branch

image

Make the implementation consistent with the Redis implementation. Make sure you are using Redis version 7.2.5 as a reference for the command implementation and to setup Redis

apoorvyadav1111 avatar Sep 07 '24 02:09 apoorvyadav1111

Can you please assign this to me? Thanks

rushabhk04 avatar Sep 07 '24 02:09 rushabhk04

Assigned. @rushabhk04 thanks for picking this up.

lucifercr07 avatar Sep 07 '24 14:09 lucifercr07

Hello @rushabhk04,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

arpitbbhayani avatar Sep 13 '24 06:09 arpitbbhayani

Hello @arpitbbhayani

I will be raising PR by 15th , currently travelling to New York!

Thanks

rushabhk04 avatar Sep 14 '24 03:09 rushabhk04