dice icon indicating copy to clipboard operation
dice copied to clipboard
verified publisher icon DiceDB

Add asserts checking non-set commands: addresses #411

Open apoorvyadav1111 opened this issue 1 year ago • 1 comments

  • The changes that are included in the PR.

Addresses #411 Added assertType for commands that are not applicable for SET Data structures.

  • Design document, if any.

Commands related to STACKINT, Queue, BITs, GET were modified to return consistent messages.

  • Information on any implementation choices that were made.

  • Evidence of sufficient testing. You MUST indicate the tests done, either manually or automated.

existing test cases pass + added new test cases to check this behaviour.

apoorvyadav1111 avatar Aug 27 '24 03:08 apoorvyadav1111

Hi @JyotinderSingh , I have added checks in most of the eval functions and added test cases in a separate file to just test unsupported data types (in order to not edit individual dedicated test files for those commands). I was unable to run JSON-related commands to verify the behavior in Redis as well as QINT commands, so I have not changed them yet.

Please share your views on the changes so far and how I can proceed with the remaining commands.

apoorvyadav1111 avatar Aug 27 '24 03:08 apoorvyadav1111

Hi @JyotinderSingh , @lucifercr07

I have updated most of the commands to handle the error messages that did not return the wrong error type. I have updated the set data encoding (strings and ints, like Redis).

Please review and share your views. If everything looks good, please merge.

Thanks, Apoorv

apoorvyadav1111 avatar Aug 28 '24 04:08 apoorvyadav1111