dice icon indicating copy to clipboard operation
dice copied to clipboard
verified publisher icon DiceDB

New feature: EXISTS k1, k2..Kn

Open apoorvyadav1111 opened this issue 1 year ago • 1 comments

  • The changes that are included in the PR. Added new command 'EXISTS' and Store function 'GetNoTouch' for getting key without updating last accessed time for that record

  • Design document, if any.

  • Information on any implementation choices that were made. This is implemented as per the Redis EXISTS command.

  • Evidence of sufficient testing. You MUST indicate the tests done, either manually or automated.

Added integration tests in test folder.

apoorvyadav1111 avatar Aug 06 '24 00:08 apoorvyadav1111

Hi @gauravsarma1992, Updated the code, Please review.

apoorvyadav1111 avatar Aug 07 '24 21:08 apoorvyadav1111

@apoorvyadav1111 there are merge conflicts with your branch. Please rebase your branch and resolve the conflicts.

gsarmaonline avatar Aug 09 '24 05:08 gsarmaonline

Hi @gauravsarma1992, resolved conflicts and rebased. Please review.

apoorvyadav1111 avatar Aug 09 '24 21:08 apoorvyadav1111

Hi @gauravsarma1992, thanks for your review. Please merge the branch at your convenience.

apoorvyadav1111 avatar Aug 10 '24 00:08 apoorvyadav1111

@JyotinderSingh can you review as well? I don't think I have write access anyway

gsarmaonline avatar Aug 10 '24 01:08 gsarmaonline