dice icon indicating copy to clipboard operation
dice copied to clipboard

Add support for `LPUSH` command

Open NOS-AE opened this issue 1 year ago • 9 comments

Add support for the LPUSH command in DiceDB similar to the LPUSH command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

NOS-AE avatar Aug 05 '24 14:08 NOS-AE

Hi @arpitbbhayani, I will like to work on this issue.

tdadadavid avatar Aug 05 '24 14:08 tdadadavid

Is it WIP or can I work on this? LPOP RPUSH RPOP will come soon too @arpitbbhayani

NOS-AE avatar Aug 05 '24 14:08 NOS-AE

please what is WIP?

tdadadavid avatar Aug 05 '24 14:08 tdadadavid

please what is WIP?

Work-In-Progress

NOS-AE avatar Aug 05 '24 14:08 NOS-AE

No, I want to pick this up and start working on it. I am still getting familiar with the codebase.

tdadadavid avatar Aug 05 '24 14:08 tdadadavid

No, I want to pick this up and start working on it. I am still getting familiar with the codebase.

Oops..I'm self assigning bro. I think you can also start a new issue like this to request for an assignment.

NOS-AE avatar Aug 05 '24 15:08 NOS-AE

okay no problem, I will watch out for these ones LPOP RPUSH RPOP

tdadadavid avatar Aug 05 '24 15:08 tdadadavid

No, I want to pick this up and start working on it. I am still getting familiar with the codebase.

Oops..I'm self assigning bro. I think you can also start a new issue like this to request for an assignment.

Assigned

JyotinderSingh avatar Aug 05 '24 18:08 JyotinderSingh

#311

NOS-AE avatar Aug 13 '24 04:08 NOS-AE