dice icon indicating copy to clipboard operation
dice copied to clipboard
verified publisher icon DiceDB

Migrating ('HLEN', 'HSTRLEN', 'HSCAN') #1024

Open c-harish opened this issue 1 year ago • 2 comments

Migrates HLEN, HSTRLEN & HSCAN commands

PR Checklist

  • [x] Migrated the evalXXX function with the latest definition
  • [x] Update or add unit tests for the new implementation.
  • [x] All unit tests pass successfully.
  • [x] Ensure all integration tests pass successfully.
  • [x] Ensure integration tests are added for the migrated command on multi-threaded resp server.
  • [x] Add http, websocket tests for the commands
  • [x] Move Integration tests for the respective commands under the RESP integration tests directory from Async directory
  • [x] Please validate that the documentation for the respective commands is up to date. If not then consider adding them.

closes #1024

c-harish avatar Oct 20 '24 08:10 c-harish

Hi, @AshwinKul28 @lucifercr07

HLEN, HSTRLEN and HSCAN are migrated and unit tests for the same are added. Integration tests for HTTP, RESP, websocket are added. Added new doc for HSTRLEN and present docs for HLEN, HSCAN looks good to me. All unit tests and integration tests passed successfully.

Please review the PR and let me know your suggestions.

Thanks

c-harish avatar Oct 21 '24 07:10 c-harish

Thanks for the review, @AshwinKul28.

Have updated the docs of commands as per sample documentation, fixed 0 return values in store_eval, added missed async testcases to resp and dropped the async integration tests of HLEN/HSTRLEN/HSCAN.

Thanks.

c-harish avatar Oct 22 '24 04:10 c-harish