Nabla icon indicating copy to clipboard operation
Nabla copied to clipboard

"treat all warnings as errors" cmake rule, macro for disabling 3rdparty includes' warnings

Open YasInvolved opened this issue 1 year ago • 6 comments

"treat all warnings as error" cmake rule, macro for disabling 3rdparty includes warnings

Description

Useful tools for dealing with warnings have been added

Testing

It wasn't really tested at all

TODO list:

  • Fix warnings with these tools

YasInvolved avatar Apr 29 '24 20:04 YasInvolved

[CI]: Can one of the admins verify this patch?

we will test it with CI once you wrap all our 3rdparty includes present in Nabla sources with those macros

AnastaZIuk avatar Apr 30 '24 05:04 AnastaZIuk

okay I need to think about it if std includes generate warnings we actually could silent them too

AnastaZIuk avatar Apr 30 '24 16:04 AnastaZIuk

okay I need to think about it if std includes generate warnings we actually could silent them too

silent all 3rdparty which are included into Nabla first, if there are errors from directly std after you do it we may silent the headers they come from too

AnastaZIuk avatar Apr 30 '24 16:04 AnastaZIuk

okay I need to think about it if std includes generate warnings we actually could silent them too

they never should

as you are on it you could turn all of our 3rdparty include directives you are wrapping with the macro which use <> into ""

AnastaZIuk avatar Apr 30 '24 19:04 AnastaZIuk