github-stats icon indicating copy to clipboard operation
github-stats copied to clipboard

Add tooltip to long PR titles

Open Balastrong opened this issue 2 years ago • 9 comments

Describe the feature

With #94 we fixed an issue on long titles, would be an additional feature to also have a tooltip when hovering on long/cut titles

It should be implemented because

No response

Additional context

No response

Would you like to work on this issue?

None

Balastrong avatar Jan 21 '24 19:01 Balastrong

I’ll work on this! :)

CBID2 avatar Jan 29 '24 07:01 CBID2

Hey @CBID2, I see something similar is being worked on #101 (no worries, the PR was opened after your comment), would you mind doing the review of that PR?

Balastrong avatar Jan 29 '24 19:01 Balastrong

Hey @CBID2, I see something similar is being worked on #101 (no worries, the PR was opened after your comment), would you mind doing the review of that PR?

Sure

CBID2 avatar Jan 29 '24 21:01 CBID2

Thank you :)

Balastrong avatar Jan 29 '24 21:01 Balastrong

Thank you :)

Can you approve the deployment in PR #101 @Balastrong? :) It was be easier for me to test this in the context of a website.

CBID2 avatar Jan 29 '24 21:01 CBID2

You're right, approved!

However let's see if it works... we had issues with login on preview builds (see #22).

The issue was on Vercel, now I switched to Nelify because Vercel didn't allow a free plan for organizations but the issue is probably still there.

If it doesn't work, you can checkout the PR branch locally :)

Balastrong avatar Jan 29 '24 21:01 Balastrong

You're right, approved!

However let's see if it works... we had issues with login on preview builds (see #22).

The issue was on Vercel, now I switched to Nelify because Vercel didn't allow a free plan for organizations but the issue is probably still there.

If it doesn't work, you can checkout the PR branch locally :)

Ok

CBID2 avatar Jan 29 '24 21:01 CBID2

I made it working using react-tooltip instead of daisy-ui's. It would be better to use the same tooltip library to maintain consistency in the codebase. @Balastrong what do you think?

theflucs avatar Feb 07 '24 15:02 theflucs

That's ok for now :)

Balastrong avatar Feb 10 '24 11:02 Balastrong