testcafe-browser-provider-browserstack icon indicating copy to clipboard operation
testcafe-browser-provider-browserstack copied to clipboard

ci: checking out wrong branch?

Open kukhariev opened this issue 3 years ago • 3 comments

It seems that now the default master build is always tested, not the PR build. image

kukhariev avatar Aug 29 '22 07:08 kukhariev

It looks like it was a one-time issue at #177. It was not reproduced in your PR #180. Have you seen this odd behavior anywhere else?

felis2803 avatar Sep 01 '22 10:09 felis2803

@felis2803 , #180 PR affected too(see actions=>Tests#45). But it's okay if I use push(--force)(actions=>Tests#46): Also #175, #179

kukhariev avatar Sep 01 '22 12:09 kukhariev

You're right. I ran some tests in #182 and #183 and found that this behavior happens quite often. I intentionally messed up the test in #182, but it was passed.

Thank you for bringing this up.

felis2803 avatar Sep 02 '22 09:09 felis2803

The bug happened when GitHub couldn't create a merge commit between the PR branch and the base branch fast enough. I refactored the code that queries the merge commit SHA, so our build system should wait until the merge commit is created. It seems that the issue is fixed now.

AndreyBelym avatar Sep 13 '22 13:09 AndreyBelym