DIM icon indicating copy to clipboard operation
DIM copied to clipboard

New filter is:uncollected

Open philkernick opened this issue 1 year ago • 1 comments

Proposed change

The vendor page has a checkbox named "only show uncollected items". I'm proposing this exact functionality be exposed as a filter is:uncollected

Other optional names for the opposite sense of the same filter is:collected is:incollection

How does this fit into your workflow?

The real use for this filter is on the records page. I want to determine which weapons I have never acquired.

I want to find the weapons highlighted below.

image

Optionally, if not a filter, then the same checkbox from the vendors page could be added to the records page.

philkernick avatar May 10 '24 13:05 philkernick

https://pr.dim.gg/10584/ has a version of this. It's a bit weird, since some items don't show as collected for some reason...

bhollis avatar Jun 20 '24 05:06 bhollis

@philkernick did you have a chance to try this out?

bhollis avatar Jul 17 '24 02:07 bhollis

I can see it's been implemented as is:collected. Which means to find the uncollected, I need -is:collected. The screenshots below have -is:collected applied.

Mostly it seems to work as expected, but I note the following minor issues.

For the craftable exotic mission catalysts they still show up as uncollected, but if I click into any of them they say unlocked in collections.

image

Emotes and ghost projects are not consistent. All of the ones that are not shaded should not be shown as I have them.

image

image

Universal ornaments are also not consistent.

image

The blue ticked ones are unlocked in collections, so shouldn't be showing here.

philkernick avatar Jul 17 '24 06:07 philkernick

Yeah, this is only implementing the same check that vendors uses, in the spirit of "I'm proposing this exact functionality be exposed as a filter is:uncollected". It doesn't have any extra logic to handle all the other special cases in collections.

bhollis avatar Jul 17 '24 19:07 bhollis

Since there hasn't been any other interest, and the definition of "collected" is so difficult, it's not worth it.

bhollis avatar Aug 31 '24 22:08 bhollis