shards-react icon indicating copy to clipboard operation
shards-react copied to clipboard

Add typescript support.

Open Saul-Mirone opened this issue 6 years ago • 17 comments

This project is great! Will you have official typescript support?

Saul-Mirone avatar May 08 '19 17:05 Saul-Mirone

I'd second this, I'm in the process of deciding whether to use this or ant.d atm

AxSch avatar Jul 15 '19 15:07 AxSch

Same, I'd love to use this with Typescript

shawnbaughcodes avatar Aug 02 '19 19:08 shawnbaughcodes

I love shard-react. The design is beautiful and elegant. Can you guys please add Typescript support

dayemsiddiqui avatar Oct 27 '19 19:10 dayemsiddiqui

+1

BendaCoding avatar Nov 03 '19 11:11 BendaCoding

@design-revision Maybe we can think about refactor by typescript or use ts declaration files?

Saul-Mirone avatar Nov 04 '19 07:11 Saul-Mirone

I have added a PR with type declarations. They arent perfect, but its a good starting point. See #31

BendaCoding avatar Dec 13 '19 22:12 BendaCoding

+1

times29 avatar Feb 14 '20 09:02 times29

@BendaCoding are the types committed and available through npm?

jordanparker6 avatar Apr 03 '20 00:04 jordanparker6

+1

theivanfranco avatar May 07 '20 22:05 theivanfranco

I would also appreciate the typescript support.

iamfj avatar Aug 19 '20 05:08 iamfj

Typescript support please!

vscatarino avatar Aug 28 '20 19:08 vscatarino

I also please very much

paszkowskik avatar Aug 31 '20 13:08 paszkowskik

++

dclipca avatar Sep 15 '20 21:09 dclipca

++++

aseerkt avatar Nov 14 '20 13:11 aseerkt

+1 This is basically a requirement of all modern UI frameworks at this point @design-revision

AdityaThyMoon avatar Jan 13 '21 20:01 AdityaThyMoon

+1 This is great project! I would appreciate typescript support. Then more better.

toyosawa avatar Apr 16 '21 10:04 toyosawa

I have found types filetypes/shards-react.d.ts in PR #31. It seems, it have not merged yet, so I extracted type declarations.

I will share this one for all, And very respect for @BendaCoding !

shards-react.d.ts.txt

I modified it a little:

  • I modified All components accept AllHTMLAttributes, =>BaseProps extends React.AllHTMLAttributes<any>.
  • I modified the type of NavbarProps.sticky to string | boolean.
  • I wraped them by declare module 'shards-react'.

usages

  • Please rename shards-react.d.ts.txt => shards-react.d.ts, and put it in your source dir.

toyosawa avatar Apr 16 '21 10:04 toyosawa