OSMeta icon indicating copy to clipboard operation
OSMeta copied to clipboard

clone big-space and drop space/FloatingOriginSettings to constants

Open Raumpatrouille opened this issue 2 years ago • 2 comments

The crate big_space uses FloatingOriginSettings (BigSpaceSettings) to let the user set the size and hysteresis of the galactic grid. We use the default values. So the values could be constants and the whole handling of the (big_)space could be dropped.

This way a space.translation_to_grid cold not be called. We add a GalacticTranslate (::new)

There are many more fn in FloatingOriginSettings. Could we move them to GridCell?

Raumpatrouille avatar Jan 06 '24 20:01 Raumpatrouille

we still would need space.translation_to_grid, we would just not need the space argument anymore. If we want to go down this route, we should rewrite the big_space crate to instead include this information in the GridCell type as an associated constant.

oli-obk avatar Jan 11 '24 09:01 oli-obk

big_space is now a local module to make all the extreme changes. The Constants are declared and used Space is removed from the application and replaced by a pub struct Space with Space::functions. (temporary)

Next: Creating classes for all types of positions. Hug the functions into the classes.

DerKarlos avatar Jan 24 '24 07:01 DerKarlos