DefinitelyTyped
Adding typescript support for WebOTP API
Please fill in this template.
- [x] Use a meaningful title for the pull request. Include the name of the package modified.
- [x] Test the change in your own code. (Compile and run.)
- [x] Add or edit tests to reflect the change.
- [x] Follow the advice from the readme.
- [x] Avoid common mistakes.
- [x] Run
pnpm test <package to test>.
If changing an existing definition:
- [x] Provide a URL to documentation or source code which provides context for the suggested changes: (https://wicg.github.io/web-otp/#otpcredential)
@plchampigny Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.
This is a live comment that I will keep updated.
1 package in this PR
Code Reviews
Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.
You can test the changes of this PR in the Playground.
Status
- ✅ No merge conflicts
- ✅ Continuous integration tests have passed
- ✅ Most recent commit is approved by type definition owners, DT maintainers or others
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.
Diagnostic Information: What the bot saw about this PR
{
"type": "info",
"now": "-",
"pr_number": 70947,
"author": "plchampigny",
"headCommitOid": "6d54aad744d465a3f2520ddf111c73d6aa6ffb58",
"mergeBaseOid": "b9405d683104ca78ff986b95e409c15387df0e95",
"lastPushDate": "2024-10-18T16:40:15.000Z",
"lastActivityDate": "2024-11-07T03:17:21.000Z",
"mergeOfferDate": "2024-11-05T19:27:54.000Z",
"mergeRequestDate": "2024-11-07T03:17:21.000Z",
"mergeRequestUser": "plchampigny",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "webappsec-credential-management",
"kind": "edit",
"files": [
{
"path": "types/webappsec-credential-management/index.d.ts",
"kind": "definition"
},
{
"path": "types/webappsec-credential-management/webappsec-credential-management-tests.ts",
"kind": "test"
}
],
"owners": [
"iainmcgin",
"Hartimer",
"Basaingeal"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "andrewbranch",
"date": "2024-11-05T19:27:16.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2422858458,
"ciResult": "pass"
}
🔔 @iainmcgin @Hartimer @Basaingeal — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.
@plchampigny Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!
Fork from previous PR: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/66279
@plchampigny The CI build failed! Please review the logs for more information.
Once you've pushed the fixes, the build will automatically re-run. Thanks!
Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review.
@sheetalkamat Could you re-review this (related to a previous review on #66279)?
Re-ping @iainmcgin, @Hartimer, @Basaingeal:
This PR has been out for over a week, yet I haven't seen any reviews.
Could someone please give it some attention? Thanks!
It has been more than two weeks and this PR still has no reviews.
I'll bump it to the DT maintainer queue. Thank you for your patience, @plchampigny.
(Ping @iainmcgin, @Hartimer, @Basaingeal.)
@plchampigny: Everything looks good here. I am ready to merge this PR (at 6d54aad) on your behalf whenever you think it's ready.
If you'd like that to happen, please post a comment saying:
Ready to merge
and I'll merge this PR almost instantly. Thanks for helping out! :heart:
(@iainmcgin, @Hartimer, @Basaingeal: you can do this too.)