DefinitelyTyped icon indicating copy to clipboard operation
DefinitelyTyped copied to clipboard

[selenium-webdriver] Add myself(Sri Harsha) as a code owner for reviews and merge

Open harsha509 opened this issue 1 year ago • 3 comments

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • [ ] The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • [ ] If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • [ ] Create it with dts-gen --dt, not by basing it on an existing project.
  • [ ] Represents shape of module/library correctly
  • [ ] tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • [ ] Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

If removing a declaration:

  • [ ] If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • [ ] Delete the package's directory.
  • [ ] Add it to notNeededPackages.json.

harsha509 avatar Oct 08 '24 15:10 harsha509

@harsha509 Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

  • selenium-webdriveron npm, on unpkg
    • 1 added owner: ✎@harsha509

@harsha509: I see that you have added yourself as an owner, are you sure you want to become an owner?

Code Reviews

Because you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 70832,
  "author": "harsha509",
  "headCommitOid": "15977dee49e18db230a63a8be6baf9e2ed505f19",
  "mergeBaseOid": "ca02214329001a17f7a9563de698c6e8c4fe8172",
  "lastPushDate": "2024-10-08T15:06:58.000Z",
  "lastActivityDate": "2024-10-29T16:06:59.000Z",
  "mergeOfferDate": "2024-10-29T16:01:45.000Z",
  "mergeRequestDate": "2024-10-29T16:06:59.000Z",
  "mergeRequestUser": "harsha509",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "selenium-webdriver",
      "kind": "edit",
      "files": [
        {
          "path": "types/selenium-webdriver/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "BillArmstrong",
        "Kuniwak",
        "cnishina",
        "SupernaviX",
        "bendxn",
        "oddui",
        "beta-vulgaris",
        "Dzenly",
        "AutomatedTester",
        "1pete",
        "SinghHrmn",
        "shubhsheth"
      ],
      "addedOwners": [
        "harsha509"
      ],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "RyanCavanaugh",
      "date": "2024-10-29T16:01:07.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 2400116584,
  "ciResult": "pass"
}

typescript-bot avatar Oct 08 '24 15:10 typescript-bot

🔔 @BillArmstrong @Kuniwak @cnishina @SupernaviX @bendxn @oddui @beta-vulgaris @Dzenly @AutomatedTester @1pete @SinghHrmn @shubhsheth — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

typescript-bot avatar Oct 08 '24 15:10 typescript-bot

Re-ping @BillArmstrong, @Kuniwak, @cnishina, @SupernaviX, @bendxn, @oddui, @beta-vulgaris, @Dzenly, @AutomatedTester, @1pete, @SinghHrmn, @shubhsheth:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

typescript-bot avatar Oct 19 '24 18:10 typescript-bot

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @harsha509.

(Ping @BillArmstrong, @Kuniwak, @cnishina, @SupernaviX, @bendxn, @oddui, @beta-vulgaris, @Dzenly, @AutomatedTester, @1pete, @SinghHrmn, @shubhsheth.)

typescript-bot avatar Oct 26 '24 18:10 typescript-bot

@harsha509: Everything looks good here. I am ready to merge this PR (at 15977de) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! :heart:

(@BillArmstrong, @Kuniwak, @cnishina, @SupernaviX, @bendxn, @oddui, @beta-vulgaris, @Dzenly, @AutomatedTester, @1pete, @SinghHrmn, @shubhsheth: you can do this too.)

typescript-bot avatar Oct 29 '24 16:10 typescript-bot

Ready to merge

harsha509 avatar Oct 29 '24 16:10 harsha509