DefinitelyTyped icon indicating copy to clipboard operation
DefinitelyTyped copied to clipboard

chore: export wicket utility types

Open llamington opened this issue 1 year ago • 3 comments

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • [x] The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • [x] If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • [x] Create it with dts-gen --dt, not by basing it on an existing project.
  • [x] Represents shape of module/library correctly
  • [x] tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

llamington avatar Jun 18 '24 02:06 llamington

@llamington Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by type definition owners, DT maintainers or others

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 31 days — it is considered abandoned, and therefore closed!


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69834,
  "author": "llamington",
  "headCommitOid": "46b5bc837debe33430c23e4359664472822fc920",
  "mergeBaseOid": "4185ae2270be9ef5bf7e11634cbf8349c4ef8d36",
  "lastPushDate": "2024-06-18T02:57:13.000Z",
  "lastActivityDate": "2024-07-15T15:38:34.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "wicket",
      "kind": "edit",
      "files": [
        {
          "path": "types/wicket/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wicket/wicket-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "llamington"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "changereq",
      "reviewer": "rbuckton",
      "date": "2024-07-14T21:41:04.000Z"
    }
  ],
  "mainBotCommentID": 2174862167,
  "ciResult": "pass"
}

typescript-bot avatar Jun 18 '24 02:06 typescript-bot

🔔 @llamington — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

typescript-bot avatar Jun 18 '24 02:06 typescript-bot

Re-ping @«anyone?»:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

typescript-bot avatar Jun 29 '24 06:06 typescript-bot

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @llamington.

(Ping @«anyone?».)

typescript-bot avatar Jul 06 '24 06:07 typescript-bot

@llamington One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

typescript-bot avatar Jul 14 '24 21:07 typescript-bot

This makes sense, I'm happy for these changes to be made

llamington avatar Jul 15 '24 15:07 llamington

@llamington I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Aug 14th (in a week) if the issues aren't addressed.

typescript-bot avatar Aug 07 '24 18:08 typescript-bot

@llamington To keep things tidy, we have to close PRs that aren't mergeable and don't have activity in the last month. No worries, though — please open a new PR if you'd like to continue with this change. Thank you!

typescript-bot avatar Aug 15 '24 18:08 typescript-bot