DefinitelyTyped icon indicating copy to clipboard operation
DefinitelyTyped copied to clipboard

[lodash] fix _.has not to be inferred to never on or operator

Open Ha-limLee opened this issue 1 year ago • 2 comments

fixed #69528

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

Ha-limLee avatar May 06 '24 14:05 Ha-limLee

@Ha-limLee Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69534,
  "author": "Ha-limLee",
  "headCommitOid": "214ee2d29de300e73e8baa1653ffcfe0ef82252c",
  "mergeBaseOid": "20f1d855d85510c51368984655e4133d520301a2",
  "lastPushDate": "2024-05-06T14:06:50.000Z",
  "lastActivityDate": "2024-05-17T01:51:39.000Z",
  "mergeOfferDate": "2024-05-16T14:05:55.000Z",
  "mergeRequestDate": "2024-05-17T01:51:39.000Z",
  "mergeRequestUser": "Ha-limLee",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "lodash",
      "kind": "edit",
      "files": [
        {
          "path": "types/lodash/common/common.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/lodash/common/object.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/lodash/lodash-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "bczengel",
        "chrootsu",
        "aj-r",
        "e-cloud",
        "thorn0",
        "jtmthf",
        "DomiR",
        "WilliamChelman"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "sandersn",
      "date": "2024-05-16T14:05:18.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "aj-r",
      "date": "2024-05-13T10:39:53.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2096108619,
  "ciResult": "pass"
}

typescript-bot avatar May 06 '24 14:05 typescript-bot

🔔 @bczengel @chrootsu @aj-r @e-cloud @thorn0 @jtmthf @DomiR @WilliamChelman — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

typescript-bot avatar May 06 '24 14:05 typescript-bot

@aj-r Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

typescript-bot avatar May 13 '24 01:05 typescript-bot

@Ha-limLee: Everything looks good here. I am ready to merge this PR (at 214ee2d) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! :heart:

(@bczengel, @chrootsu, @aj-r, @e-cloud, @thorn0, @jtmthf, @DomiR, @WilliamChelman: you can do this too.)

typescript-bot avatar May 16 '24 14:05 typescript-bot

Ready to merge

Ha-limLee avatar May 17 '24 01:05 Ha-limLee