[@types/react-datepicker] fix: remove named export
- [x] Use a meaningful title for the pull request. Include the name of the package modified.
- [x] Test the change in your own code. (Compile and run.)
- [x] Add or edit tests to reflect the change.
- [x] Follow the advice from the readme.
- [x] Avoid common mistakes.
- [x] Run
pnpm test <package to test>. - [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/Hacker0x01/react-datepicker/blob/main/src/index.jsx#L79
- [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the
package.json.
The library does not export the component as a named export, only as a default. It is currently possible to import the component (ReactDatePicker) as a named export though, which breaks everything. This PR fixes it.
@paolostyle Thank you for submitting this PR!
This is a live comment which I will keep updated.
1 package in this PR
Code Reviews
Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.
You can test the changes of this PR in the Playground.
Status
- ✅ No merge conflicts
- ✅ Continuous integration tests have passed
- ✅ Most recent commit is approved by type definition owners or DT maintainers
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.
Diagnostic Information: What the bot saw about this PR
{
"type": "info",
"now": "-",
"pr_number": 68709,
"author": "paolostyle",
"headCommitOid": "8f3988ab4b57e55005b374aabc60ca2ee7468a68",
"mergeBaseOid": "bfa046ce6231e0337ddea587c3f5e5ba307513e0",
"lastPushDate": "2024-02-20T21:13:37.000Z",
"lastActivityDate": "2024-03-04T00:35:56.000Z",
"mergeOfferDate": "2024-03-03T13:58:15.000Z",
"mergeRequestDate": "2024-03-04T00:35:56.000Z",
"mergeRequestUser": "paolostyle",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "react-datepicker",
"kind": "edit",
"files": [
{
"path": "types/react-datepicker/index.d.ts",
"kind": "definition"
},
{
"path": "types/react-datepicker/react-datepicker-tests.tsx",
"kind": "test"
}
],
"owners": [
"radziksh",
"smrq",
"royxue",
"KoalaHuman",
"justingrant",
"aviklai",
"seckie",
"kerry-g",
"ShiftrTechSAS",
"1pete",
"y",
"inomn"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "seckie",
"date": "2024-03-03T13:57:32.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1955108106,
"ciResult": "pass"
}
🔔 @radziksh @smrq @royxue @KoalaHuman @justingrant @aviklai @seckie @kerry-g @ShiftrTechSAS @1pete @y @inomn — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.
Re-ping @radziksh, @smrq, @royxue, @KoalaHuman, @justingrant, @aviklai, @seckie, @kerry-g, @ShiftrTechSAS, @1pete, @y, @inomn:
This PR has been out for over a week, yet I haven't seen any reviews.
Could someone please give it some attention? Thanks!
@paolostyle: Everything looks good here. I am ready to merge this PR (at 8f3988a) on your behalf whenever you think it's ready.
If you'd like that to happen, please post a comment saying:
Ready to merge
and I'll merge this PR almost instantly. Thanks for helping out! :heart:
(@radziksh, @smrq, @royxue, @KoalaHuman, @justingrant, @aviklai, @seckie, @kerry-g, @ShiftrTechSAS, @1pete, @y, @inomn: you can do this too.)
Ready to merge