DefinitelyTyped icon indicating copy to clipboard operation
DefinitelyTyped copied to clipboard

Update eslint rules option declation

Open linlinyang opened this issue 1 year ago • 5 comments

linlinyang avatar Feb 18 '24 07:02 linlinyang

@linlinyang Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Inactive

This PR has been inactive for 5 days.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 68677,
  "author": "linlinyang",
  "headCommitOid": "2e8f99a2942a5fdf407fde8148397db6e525d571",
  "mergeBaseOid": "b1f4c516f422e0fea286713b7690d3afc7581953",
  "lastPushDate": "2024-02-18T07:49:21.000Z",
  "lastActivityDate": "2024-02-22T22:37:46.000Z",
  "mergeOfferDate": "2024-02-22T22:38:25.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "eslint",
      "kind": "edit",
      "files": [
        {
          "path": "types/eslint/rules/ecmascript-6.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "pmdartus",
        "j-f1",
        "saadq",
        "JasonHK",
        "bradzacher",
        "JounQin"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "rbuckton",
      "date": "2024-02-22T22:37:46.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "bradzacher",
      "date": "2024-02-18T08:27:33.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1950993509,
  "ciResult": "pass"
}

typescript-bot avatar Feb 18 '24 07:02 typescript-bot

🔔 @pmdartus @j-f1 @saadq @JasonHK @bradzacher @JounQin — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

typescript-bot avatar Feb 18 '24 07:02 typescript-bot

:hourglass_flowing_sand: Hi @linlinyang,

It's been a few days since this PR was approved by rbuckton, bradzacher and we're waiting for a DT maintainer to give a review.

If you would like to short-circuit this wait, you can edit some of the test files in the package which verify how the .d.ts files work. This would allow the PR to be merged by you or the DT module owners after a re-review.

typescript-bot avatar Feb 22 '24 12:02 typescript-bot

merged into

linlinyang avatar Feb 28 '24 09:02 linlinyang